recommend use of an api cache library in the style guide #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a8f0198:
|
|
✔️ Deploy Preview for redux-docs ready! 🔨 Explore the source changes: dff5998 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-docs/deploys/6150288c04f4890008d2a2e6 😎 Browse the preview: https://deploy-preview-4178--redux-docs.netlify.app |
|
I'd probably put this one in the later "Recommended" section, alongside "Use Thunks". |
3imed-jaberi
approved these changes
Aug 14, 2022
EskiMojo14
force-pushed
the
style-guide-rtk-query
branch
from
dff5998 to
a8f0198
Compare
|
this seems to have been superceded by #4460 - (https://redux.js.org/style-guide/#use-rtk-query-for-data-fetching) okay to close? |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 📖 Recommend use of an api cache library in the style guide
about: Add a section to the style guide to use RTK Query or an alternative library.
PR Type
Update an existing page
Checklist
No, the linter runs amok on my local machine and tries to format everything differently.
What docs page is being added or updated?
For Updating Existing Content
What updates should be made to the page?
Add a section to the style guide to use RTK Query or an alternative library.
Do these updates change any of the assumptions or target audience? If so, how do they change?
They add more emphasis that api cache logic should usually not be written by hand.
@markerikson generally I am very open to pretty much rewording anything in here, but we should probably get RTK-Q mentioned in the style guide.