-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1382 - React Native - Hermes Engine isn't supporting for await
yet
#1430
Conversation
|
for await
very wellfor await
yet
omg can we please merge this! with all the problems flipper and hermes has, this is the only way to use redux devtools on react native right now. Is there any blocker or anything I can do? |
Sorry for the late response! This should be fixed in |
@Methuselah96 I'm on
I'm thinking it is related to this issue, but I'm not sure.
|
@Methuselah96 Yep, this is not fixed. I will continue using the patch. |
Hello!
This PR fixes #1382. Shortly, React Native's JavaScript Engine, Hermes, isn't supporting
for await
syntax yet (see facebook/hermes#1089) and with the changes in this PR,@redux-devtools/remote
can used by React Native developers.Additional context: Question #1429 from Discussions section
I had some issues with TypeScript here and there, most of them I actually inherited when forking the project. Would appreciate some help fixing them.
Thank you!