-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate type tests to Vitest #2129
Migrate type tests to Vitest #2129
Conversation
…patch.test-d.tsx`
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
Haven't paid any attention to this, I'm afraid :) Where's it stand? I see green. Also, just out of curiosity, what's the net benefit of doing typetests with Vitest? |
…emami59/react-redux; branch 'master' of https://github.com/reduxjs/react-redux into migrate-typetests-to-vitest
@markerikson All tests are passing.
On a side note I'm also a collaborator on the |
…migrate-typetests-to-vitest
…migrate-typetests-to-vitest
Okay, cloned it briefly and confirmed A) it passes locally, B) it does catch errors if I introduce them. Nice! |
This PR:
typetest.ts
file extensions totest-d.ts
to be compatible with Vitest.expectType()
to eitherassertType()
orexpectTypeOf().toMatchTypeOf()
.expectExactType
toexpectTypeOf().toEqualTypeOf()
.test
ordescribe
blocks.