Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: yara-python-dex installation #411

Closed
wants to merge 3 commits into from
Closed

Fix: yara-python-dex installation #411

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81cb8d9
Fix: yara-python-dex installation
AbhiTheModder Oct 27, 2024
3bbba53
Update setup.py
AbhiTheModder Oct 27, 2024
91ac8ef
Merge branch 'rednaga:master' into fix/yara
AbhiTheModder Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def package_files(directory):


install_requires = [
'yara-python-dex>=1.0.1',
"yara-python-dex @ git+https://github.com/MobSF/yara-python-dex.git",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of file uses simple commas (') instead of double commas (")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a risky change?

Copy link
Contributor Author

@AbhiTheModder AbhiTheModder Oct 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a risky change?

Yes, it could be that is why I was hesitant to raise the merge request, but there's no solution instead of it on termux(android), even if we go with toml setup we'll have to add git+https://github.com/MobSF/yara-python-dex.git in requirements for it to be able to complete installation successfully.

Or how about adding a note for It's installation on README?

afaik I've seen in yara-python-dex repo the yara submodule still on the commit of 4yrs old(maintainer mostly changes ci files) so it doesn't feel like something major will arise

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we pointing folks at a prebuilt thing that isn't controlled from the source we maintain? That feels bad.

I know I haven't been a good maintainer and been looking at this for a while, however if there are changes in the branched thing you're pointing at, why not just make a PR to the actual branch we control?

]

dev_requires = [
Expand Down