Skip to content

Commit

Permalink
(docs) Windows update README.md (#400)
Browse files Browse the repository at this point in the history
  • Loading branch information
AndroidMaster24 authored Oct 14, 2024
1 parent d30d103 commit a22b65c
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ If you want to install the latest version in order to make changes, develop your
```bash
git clone https://github.com/rednaga/APKiD
cd APKiD
./prep-release.py
python prep-release.py
pip install -e .[dev,test]
```

Expand All @@ -105,6 +105,15 @@ pip install -e .[dev,test] --user

If you update any of the rules, be sure to run `prep-release.py` to recompile them.

If you are using Windows, install Yara 3.11.0 and yara-python-dex before compiling

```bash
pip install yara-python==3.11.0
pip install wheel
pip wheel --wheel-dir=yara-python-dex git+https://github.com/MobSF/yara-python-dex.git
pip install --no-index --find-links=yara-python-dex yara-python-dex
```

## For Package Maintainers

When releasing a new version, make sure the version has been updated in [apkid/__init__.py](apkid/__init__.py).
Expand Down

1 comment on commit a22b65c

@strazzere
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sentiment as this comment;

#411 (comment)

While nothing is inherently bad by doing this (currently?) the source is basically pointing elsewhere to get precompiled things without understanding the implications.

I know I haven't been the best maintainer, but this feels like a bad recommendation to give people to blindly copy/paste.

Please sign in to comment.