Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add Support for Declaring Vector Fields in JsonModel with Relevant Unit Tests #674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

huwaizatahir2
Copy link

@huwaizatahir2 huwaizatahir2 commented Dec 9, 2024

Issue Reference:
#656

This pull request addresses the inability to declare vector fields in JsonModel, as described in the referenced issue. The following updates are introduced to resolve the issue and enhance functionality:

Fixes

  • Enabled the declaration of vector fields in JsonModel by refining the Field initialization logic and ensuring compatibility with VectorFieldOptions.
  • Improved type inference for vector field annotations to align with Pythonic standards.

Additions

Unit Tests:

  • Comprehensive tests for vector field declaration, schema generation, and functionality in JsonModel.
  • Debug-specific test to investigate syntax errors related to vector fields, ensuring schema validity without redundant assertions.
  • Updated test_literals to fix discrepancies in primary key validation for related tests.

Outcomes

  • Fixed the syntax error when declaring vector fields in JsonModel.
  • Validated vector field schema generation and runtime behavior with additional tests.
  • Enhanced code quality and consistency with idiomatic Python practices and doc-strings.

@huwaizatahir2
Copy link
Author

Hi @slorello89 @banker @simonprickett @chayim, can we please have a look at this PR, thanks

@huwaizatahir2
Copy link
Author

Hi @slorello89 @banker @simonprickett @chayim, can we please have a look at this PR, thanks

@slorello89 @banker @simonprickett @chayim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant