Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotations for models #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type annotations for models #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aredis_om/model/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,7 @@ async def delete(
return await cls._delete(db, cls.make_primary_key(pk))

@classmethod
async def get(cls, pk: Any) -> "RedisModel":
async def get(cls:type[_T], pk: Any) -> _T:
raise NotImplementedError

async def update(self, **field_values):
Expand Down Expand Up @@ -1368,7 +1368,7 @@ async def all_pks(cls): # type: ignore
)

@classmethod
async def get(cls, pk: Any) -> "HashModel":
async def get(cls:type[_T], pk: Any) -> _T:
document = await cls.db().hgetall(cls.make_primary_key(pk))
if not document:
raise NotFoundError
Expand Down Expand Up @@ -1559,7 +1559,7 @@ async def update(self, **field_values):
await self.save()

@classmethod
async def get(cls, pk: Any) -> "JsonModel":
async def get(cls:type[_T], pk: Any) -> _T:
document = json.dumps(await cls.db().json().get(cls.make_key(pk)))
if document == "null":
raise NotFoundError
Expand Down