-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support null values for optional fields #340
Open
wiseaidev
wants to merge
6
commits into
redis:main
Choose a base branch
from
wiseaidev:fix-optional-fields
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wiseaidev <[email protected]>
Signed-off-by: wiseaidev <[email protected]>
wiseaidev
force-pushed
the
fix-optional-fields
branch
from
August 9, 2022 20:03
64e4960
to
1efdbdf
Compare
Signed-off-by: wiseaidev <[email protected]>
wiseaidev
force-pushed
the
fix-optional-fields
branch
4 times, most recently
from
August 10, 2022 16:15
f260efe
to
c483098
Compare
Signed-off-by: wiseaidev <[email protected]>
wiseaidev
force-pushed
the
fix-optional-fields
branch
from
August 10, 2022 16:17
c483098
to
79cf5bf
Compare
@wiseaidev It doesn't seem to have solved the problem, the tests are failing. |
Hey @dvora-h, sorry, i was AFK. Working on it, not finished yet! Marking it as a work in progress! |
wiseaidev
changed the title
Support null values for optional fields
[WIP] Support null values for optional fields
Aug 11, 2022
Signed-off-by: wiseaidev <[email protected]>
wiseaidev
force-pushed
the
fix-optional-fields
branch
from
August 12, 2022 08:06
a721dbc
to
a6cca90
Compare
Signed-off-by: wiseaidev <[email protected]>
wiseaidev
force-pushed
the
fix-optional-fields
branch
from
August 12, 2022 08:13
a6cca90
to
187ca0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #261 & #254
The query is working, the only issue is that the
await model.save()
call returns the values stored in Redis, i also need to apply this workaround to this method that i am currently trying to find out how.The string zero "0" is the null value rather than the empty string cause it is a valid int and float, not sure if someone want to store "0" in the database as a string value, highly unlikely.
Test case example:
I think the only solution is to override
self
or construct a new object with these values(None in place of "0").