Add result_fact_cacheable var (#231)

* Fix cacheable for parse_leapp_report * change var to match previous PR * Adding changelog for change --------- Co-authored-by: Kaleb Stolee <[email protected]>
redhat-cop · Nov 14, 2024 · db1f54b · db1f54b
1 parent eb7e13c
commit db1f54b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/changelogs/fragments/add_cachable_variable.yml b/changelogs/fragments/add_cachable_variable.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+- Add optional parameter for allowing caching of facts within AAP
diff --git a/roles/parse_leapp_report/README.md b/roles/parse_leapp_report/README.md
@@ -7,8 +7,9 @@ The `parse_leapp_report` role is used by the `analysis` or `upgrade` roles to ch
 | Name                    | Default value         | Description                                         |
 |-------------------------|-----------------------|-----------------------------------------------------|
 | result_filename         | "/var/log/leapp/leapp-report.txt" | Path of the Leapp pre-upgrade report file. |
-| result_filename_prefix  | "/var/log/leapp/leapp-report      | The path used and the prefix name setting for the Leapp report |
-| result_filename_json    | "{{ result_filename_prefix }}.json | JSON filename using the selected "result_filename_prefix" |
+| result_filename_prefix  | "/var/log/leapp/leapp-report"      | The path used and the prefix name setting for the Leapp report |
+| result_filename_json    | "{{ result_filename_prefix }}.json" | JSON filename using the selected "result_filename_prefix" |
+| result_fact_cacheable    | false | Allow the results from parsing the LEAPP report be cacheable (primarily for AAP) |
 
 ## Example playbook
 

diff --git a/roles/parse_leapp_report/defaults/main.yml b/roles/parse_leapp_report/defaults/main.yml
@@ -2,4 +2,5 @@
 # defaults file for parse_leapp_report
 result_filename_prefix: /var/log/leapp/leapp-report
 result_filename_json: "{{ result_filename_prefix }}.json"
+result_fact_cacheable: false
 ...
diff --git a/roles/parse_leapp_report/tasks/main.yml b/roles/parse_leapp_report/tasks/main.yml
@@ -15,11 +15,13 @@
 
 - name: Parse report results
   ansible.builtin.set_fact:
+    cacheable: "{{ result_fact_cacheable }}"
     leapp_report_txt: "{{ results_txt.content | b64decode | split('\n') }}"
     leapp_report_json: "{{ results_json.content | b64decode | from_json }}"
 
 - name: Check for inhibitors
   ansible.builtin.set_fact:
+    cacheable: "{{ result_fact_cacheable }}"
     upgrade_inhibited: true
     leapp_inhibitors: "{{ leapp_inhibitors | default([]) + [item] }}"
   when: