Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RHTAP-3416 'template' command uses the wrong namespace #368

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Jan 3, 2025

  • The chart release namespace is retrieved from the config.yaml.
  • Helm connects to the server to provide an accurate rendering of the templates.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@Roming22 Roming22 requested a review from otaviof January 3, 2025 21:46
@openshift-ci openshift-ci bot requested review from flacatus and prietyc123 January 3, 2025 21:46
@openshift-ci openshift-ci bot added the approved label Jan 3, 2025
@otaviof
Copy link
Collaborator

otaviof commented Jan 6, 2025

/retest

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me understand the reasons behind the dry-run changes, please.

pkg/deployer/helm.go Show resolved Hide resolved
installer/charts/rhtap-dh/values.yaml Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@xinredhat
Copy link
Member

/lgtm

@Roming22
Copy link
Member Author

Roming22 commented Jan 7, 2025

@otaviof I've fixed your comment, and answered your questions. I've also added an extra commit to fix an issue created by a recent commit.

PTAL.

- The chart release namespace is retrieved from the config.yaml.
- Helm connects to the server to provide an accurate rendering of the
  templates.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Copy link

sonarqubecloud bot commented Jan 7, 2025

@xinredhat
Copy link
Member

/retest

1 similar comment
@Roming22
Copy link
Member Author

Roming22 commented Jan 8, 2025

/retest

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

With a single remark about the dry-run mode 😊

@@ -68,7 +68,7 @@ func (h *Helm) helmInstall(vals chartutil.Values) (*release.Release, error) {
c.DryRun = h.flags.DryRun
c.ClientOnly = h.flags.DryRun
if h.flags.DryRun {
c.DryRunOption = "client"
c.DryRunOption = "server"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using client means Helm dry-run mode validates configurations locally, while server dry-run mode sends the request to the API server for full validation without persisting changes. We can improve this later, let's highlight that 👍

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2025
Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6337b92 into redhat-appstudio:main Jan 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants