-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RHTAP-3416 'template' command uses the wrong namespace #368
fix: RHTAP-3416 'template' command uses the wrong namespace #368
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me understand the reasons behind the dry-run changes, please.
/lgtm |
@otaviof I've fixed your comment, and answered your questions. I've also added an extra commit to fix an issue created by a recent commit. PTAL. |
- The chart release namespace is retrieved from the config.yaml. - Helm connects to the server to provide an accurate rendering of the templates. rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Quality Gate passedIssues Measures |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
With a single remark about the dry-run mode 😊
@@ -68,7 +68,7 @@ func (h *Helm) helmInstall(vals chartutil.Values) (*release.Release, error) { | |||
c.DryRun = h.flags.DryRun | |||
c.ClientOnly = h.flags.DryRun | |||
if h.flags.DryRun { | |||
c.DryRunOption = "client" | |||
c.DryRunOption = "server" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using client
means Helm dry-run mode validates configurations locally, while server
dry-run mode sends the request to the API server for full validation without persisting changes. We can improve this later, let's highlight that 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: otaviof, Roming22 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6337b92
into
redhat-appstudio:main
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED