Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ACS to 4.6 and enable scannerV4 #299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update ACS to 4.6 and enable scannerV4 #299

wants to merge 2 commits into from

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented Nov 5, 2024 •
edited by openshift-ci bot
Loading

Recommended configuration after reaching out the ACS team regarding RHTAPBUGS-1316

@openshift-ci openshift-ci bot requested review from flacatus and xinredhat November 5, 2024 14:45
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@Roming22
Copy link
Member Author

Roming22 commented Nov 5, 2024

/retest

1 similar comment
@xinredhat
Copy link
Member

/retest

@Roming22 Roming22 marked this pull request as draft November 8, 2024 13:33
@Roming22 Roming22 changed the title fix: Enable scannerV4 in ACS [WIP] fix: Enable scannerV4 in ACS Nov 8, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@Roming22 Roming22 requested a review from otaviof January 8, 2025 20:47
@Roming22 Roming22 changed the title [WIP] fix: Enable scannerV4 in ACS Update ACS to 4.6 and enable scannerV4 Jan 8, 2025
@Roming22 Roming22 marked this pull request as ready for review January 8, 2025 20:48
@openshift-ci openshift-ci bot requested a review from prietyc123 January 8, 2025 20:48
@Roming22 Roming22 force-pushed the fix/acs/config branch 2 times, most recently from 3f4eba1 to a306a76 Compare January 8, 2025 21:05
lcarva
lcarva reviewed Jan 8, 2025
View reviewed changes
installer/charts/rhtap-acs-scanner/scripts/test-acs-image-scan.sh
export ROX_CENTRAL_ENDPOINT
export ROX_API_TOKEN

IMAGE="${IMAGE:-quay.io/fedora/fedora:36-x86_64@sha256:d6e4c7d6d1eaa24d71c8efd7432890acdc0179502224d0aaad6bb05d15ffde19}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand it's only used for testing the installation, but can we use an image from registry.redhat.io instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's more complicated than just switching the image, as ACS would need to be setup to be integrated with registry.redhat.io (it's basically currently returning an error saying it can't get the image from that registry).

I've chosen as close to possible to a "Red Hat" image by using a Fedora image hosted on quay, which are 2 products strongly linked to our brand. Let me know if you don't think that's good enough.

@Roming22
feat: Upgrade to ACS 4.6
79baa2b 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@Roming22
fix: Enable scannerV4 in ACS
0f38ec0 
Recommended configuration after reaching out the ACS team regarding RHTAPBUGS-1316.
Must not be merged before ACS has been updated to 4.6.

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
7 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva left review comments

@flacatus flacatus Awaiting requested review from flacatus

@xinredhat xinredhat Awaiting requested review from xinredhat

@otaviof otaviof Awaiting requested review from otaviof

@prietyc123 prietyc123 Awaiting requested review from prietyc123

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Roming22 @xinredhat @lcarva