Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove references to jvm-build-service #5132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove references to jvm-build-service #5132

wants to merge 2 commits into from
+4,855 −323

Conversation

tnevrlka
Copy link
Member

  • jvm-build-service is currently not being used by anyone
  • It is going to undergo major breaking changes and is going to be removed for now until the changes are done

Split into two commits:

  • first is removing the references in most of the repository.
  • second is removing references to jbs in components/sandbox/tiers

The second commit contains files created by ksctl as mentioned in https://github.com/redhat-appstudio/infra-deployments/blob/main/components/sandbox/tiers/README.adoc leading to thousands of newly added lines

@openshift-ci openshift-ci bot requested review from chmeliik and mmorhun December 12, 2024 19:43
@tnevrlka
Copy link
Member Author

/hold

chmeliik
chmeliik reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual changes LGTM, just not sure why something ended up generating 5000 lines of new stuff 😕

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 7e261f7 to 6c6aed6 Compare December 13, 2024 16:56
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 6c6aed6 to de8f0d2 Compare December 17, 2024 09:59
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from de8f0d2 to 6fc49e7 Compare December 17, 2024 10:06
@tnevrlka
Copy link
Member Author

tnevrlka commented Dec 17, 2024 •
edited
Loading

The manual changes LGTM, just not sure why something ended up generating 5000 lines of new stuff 😕

It scares me a little bit, but it kinda makes sense to me when you consider this PR which only changes the maintainer file and has 1225 newly added lines.

I've changed four files which could result in 4 times as many lines.
Sanity check: 1225*4=4900, I have around 4854. Q.E.D.

It seems like it might be a good idea to get someone from infra to take a look at this though

@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 6fc49e7 to 430f589 Compare December 20, 2024 15:16
@tnevrlka
remove references to jvm-build-service
1b4ef60 
- jvm-build-service is currently not being used by anyone
- It is going to undergo major breaking changes and is going to be removed for now until the changes are done
@tnevrlka
remove references to jbs in sandbox/tiers
007b6ae 
- There are mentions of jvm-build-service in components/sandbox/tiers
- Manually remove the references from `components/sandbox/tiers/src`
- Run `ksctl generate nstemplatetiers --source ./src --out-dir ./production` as mentioned in README (same for staging) which automatically generates many new files
@tnevrlka tnevrlka force-pushed the remove-jvm-build-service branch from 430f589 to 007b6ae Compare January 20, 2025 09:56
@tnevrlka tnevrlka mentioned this pull request Jan 20, 2025
Open
9 tasks
chmeliik
chmeliik approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 21, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chmeliik, tnevrlka
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hugares
Copy link
Contributor

hugares commented Jan 21, 2025

/hold
We did a few changes to the tiers since this change was originally written. We might need to rebase and re-generate the tiers. Blocking this change, I will verify it later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun left review comments

@hugares hugares hugares left review comments

@chmeliik chmeliik chmeliik approved these changes

Assignees

@chmeliik chmeliik

Labels
do-not-merge/hold lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tnevrlka @hugares @mmorhun @chmeliik @openshift-merge-robot