Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split aperture section, styling changes #26

Merged
merged 10 commits into from
Mar 1, 2024
Merged

refactor: split aperture section, styling changes #26

merged 10 commits into from
Mar 1, 2024

Conversation

wizzdom
Copy link
Member

@wizzdom wizzdom commented Feb 13, 2024

No description provided.

@wizzdom
Copy link
Member Author

wizzdom commented Mar 1, 2024

Okay here we go:

  • remove aperture section and split it up, it shouldn't be treated any differently from the rest of the docs
  • add a custom footer with social icons and the Redbrick logo
  • add some extensions to make codeblocks look and work nicer
  • add GLightbox: makes viewing images easier and allows zoom
  • add mkdocs-redirects to auto-redirect any old links for the old aperture section to their new locations
  • crop empty space from the logo to make it appear bigger on the site
  • update the GitHub ci to latest

@wizzdom wizzdom requested a review from DistroByte March 1, 2024 14:15
@wizzdom wizzdom marked this pull request as ready for review March 1, 2024 14:15
@wizzdom wizzdom force-pushed the refactor-aperture branch from 4f1e057 to dd2782c Compare March 1, 2024 15:45
@wizzdom wizzdom requested a review from HypnoAnt March 1, 2024 19:25
DistroByte
DistroByte reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@DistroByte DistroByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about hardcoded email, other than that LGTM

HypnoAnt
HypnoAnt approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@HypnoAnt HypnoAnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just look at James' question otherwise looks good to me.

@wizzdom wizzdom merged commit 7a91dee into master Mar 1, 2024
@wizzdom wizzdom deleted the refactor-aperture branch March 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DistroByte DistroByte DistroByte left review comments

@HypnoAnt HypnoAnt HypnoAnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizzdom @DistroByte @HypnoAnt