Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook warning in bucket and obc creation #1682

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing TimothyAsirJeyasing commented Nov 15, 2024

@TimothyAsirJeyasing
Copy link
Contributor Author

Screenshot from 2024-11-12 13-06-49

@TimothyAsirJeyasing
Copy link
Contributor Author

After:
Screenshot from 2024-11-15 11-43-31
Screenshot from 2024-11-15 11-42-46
Screenshot from 2024-11-15 11-42-15

@TimothyAsirJeyasing
Copy link
Contributor Author

/test images

@alfonsomthd
Copy link
Collaborator

/lgtm

@alfonsomthd
Copy link
Collaborator

LGTM. @SanjalKatiyar @bipuladh to add approve tag.

@alfonsomthd
Copy link
Collaborator

/approve cancel

@SanjalKatiyar
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.18

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.18-compatibility

@openshift-cherrypick-robot

@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.18-compatibility in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit dd82d1d into red-hat-storage:master Nov 25, 2024
5 checks passed
@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1713

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@SanjalKatiyar: new pull request created: #1714

In response to this:

/cherry-pick release-4.18-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TimothyAsirJeyasing
Copy link
Contributor Author

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1779

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1780

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1781

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TimothyAsirJeyasing
Copy link
Contributor Author

/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility
/cherry-pick release-4.15-compatibility

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1786

In response to this:

/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility
/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1787

In response to this:

/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility
/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@TimothyAsirJeyasing: new pull request created: #1788

In response to this:

/cherry-pick release-4.17-compatibility
/cherry-pick release-4.16-compatibility
/cherry-pick release-4.15-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants