feat: update

red-armor · Jan 5, 2025 · 2cf3e28 · 2cf3e28
1 parent 91bc865
commit 2cf3e28
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/ui/scroller/src/react-native/Marshal.ts b/ui/scroller/src/react-native/Marshal.ts
@@ -62,7 +62,7 @@ class Marshal {
     outerMostVerticalMarshal: Marshal;
     outerMostHorizontalMarshal: Marshal;
     removeClippedSubviews: boolean;
-    ref: MutableRefObject<ScrollView | View | undefined>;
+    ref: SpectrumScrollViewRef;
   }) {
     const {
       id,

diff --git a/ui/scroller/src/react-native/ScrollEventHelper.ts b/ui/scroller/src/react-native/ScrollEventHelper.ts
@@ -15,7 +15,6 @@ import Marshal from './Marshal';
  * ScrollEventHelper is bound to ScrollView, Every ScrollView will has its own
  * `ScrollEventHelper`. then ScrollEventHelper will register to ScrollHelper,
  * the ScrollEventHelper event is actually triggered by root ScrollHelper.
- *
  */
 class ScrollEventHelper {
   private _disposer: Function;
@@ -28,7 +27,7 @@ class ScrollEventHelper {
   private _onMomentumScrollBegin: SyntheticEventHandler | undefined;
   private _onScrollToTop: SyntheticEventHandler | undefined;
   private _subscriptions: ScrollEventHandlerSubscriptions;
-  private _onEndReached: (props: { distanceFromEnd: number }) => void;
+  private _onEndReached?: (props: { distanceFromEnd: number }) => void;
   public marshal: Marshal;
 
   constructor(props: {

diff --git a/ui/scroller/src/react-native/ScrollHelper.ts b/ui/scroller/src/react-native/ScrollHelper.ts
@@ -273,6 +273,16 @@ class ScrollHelper {
     this._marshal.dimensions.updateScrollMetrics(this._scrollMetrics);
   }
 
+  /**
+   *
+   * @returns
+   *
+   * To ensure the nested reverse direction ScrollView should be in considered..
+   * for example, vertical ScrollView include a horizontal ScrollView, when scrolling
+   * on vertical ScrollView, the horizontal ScrollView should be checked whether it
+   * is in viewport as well...
+   *
+   */
   prepareNested() {
     const dimensions = this.getItemsDimensions();
     if (!dimensions) return null;