Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add destroy method for AlternatePaymentMethod class #901

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add destroy method for AlternatePaymentMethod class #901

merged 1 commit into from
Sep 27, 2024
+22 −0

Conversation

Patrick-Duvall
Copy link
Contributor

@Patrick-Duvall Patrick-Duvall commented Sep 27, 2024 •
edited
Loading

Adds destroy method to alternative-payment-methods. Calling this method removes and destroys the adyen web component, allowing it to subsequently be re-rendered without a page reload.

@chrissrogers chrissrogers changed the title [EE-4326] Add destroy method for AlternatePaymentMethod class Add destroy method for AlternatePaymentMethod class Sep 27, 2024
mwlang
mwlang approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mwlang mwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this exposes the means for merchants to call #destroy() on demand. No changes to RJS internals to automatically destroy and re-render.

@recurly recurly deleted a comment from ssnyder13 Sep 27, 2024
@chrissrogers chrissrogers merged commit b8ed11a into master Sep 27, 2024
26 of 27 checks passed
@chrissrogers chrissrogers deleted the EE-4326 branch September 27, 2024 20:04
recurly-integrations pushed a commit that referenced this pull request Sep 27, 2024
4.30.1
168095b 
[Full Changelog](v4.30.0...v4.30.1)

**Merged Pull Requests**

- Add destroy method for AlternatePaymentMethod class [#901](#901) ([Patrick-Duvall](https://github.com/Patrick-Duvall))

##### Minified MD5 Checksum
```
13b98adfe32284423cf92a8f826e18f5 ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
viI7Vx2xNBeIML8D1b1L/vM08jT4rqarb5fUd/kgUPmtnUOlY6eKhCFyg76mZrpr
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrissrogers chrissrogers chrissrogers approved these changes

@mwlang mwlang mwlang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Patrick-Duvall @mwlang @chrissrogers