Merge pull request #888 from recurly/pricing-zero-qty-subs

Allows subscription quantities of zero on Pricing instances
recurly · Jul 16, 2024 · e8dd7e5 · e8dd7e5
2 parents 8dce434 + d2be988
commit e8dd7e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/recurly/pricing/subscription/calculations.js b/lib/recurly/pricing/subscription/calculations.js
@@ -272,7 +272,9 @@ export default class Calculations {
     const plan = this.items.plan;
     if (!plan) return { amount: 0, setup_fee: 0 };
     let price = plan.price[this.items.currency];
-    price.amount = price.unit_amount * (plan.quantity || 1);
+    let quantity = parseInt(plan.quantity, 10);
+    if (isNaN(quantity)) quantity = 1;
+    price.amount = price.unit_amount * quantity;
     return price;
   }
 

diff --git a/lib/recurly/pricing/subscription/index.js b/lib/recurly/pricing/subscription/index.js
@@ -371,8 +371,9 @@ export default class SubscriptionPricing extends Pricing {
 
     // options.quantity, plan.quantity, 1
     if (plan && plan.quantity) quantity = plan.quantity;
-    if (options.quantity) quantity = parseInt(options.quantity, 10);
-    if (!quantity || quantity < 1) quantity = 1;
+
+    if ('quantity' in options) quantity = parseInt(options.quantity, 10);
+    if (isNaN(quantity) || quantity < 0) quantity = 1;
 
     return { currentPlan: plan, quantity, planCode, options, done };
   }