Workaround a jQuery bug

recurly · Aug 23, 2013 · af7c455 · af7c455
1 parent e7453e3
commit af7c455
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 10 deletions.
diff --git a/build/recurly.js b/build/recurly.js
@@ -1,4 +1,4 @@
-//   Recurly.js - v2.2.3
+//   Recurly.js - v2.2.4
 //
 //   Communicates with Recurly <https://recurly.com> via a JSONP API,
 //   generates UI, handles user error, and passes control to the client
@@ -50,7 +50,7 @@ R.settings = {
 , oneErrorPerField: true
 };
 
-R.version = '2.2.3';
+R.version = '2.2.4';
 
 R.dom = {};
 
@@ -1260,10 +1260,10 @@ function initCommonForm($form, options) {
     var $li = $(this).parent(); 
 
     if($input.val().length > 0) {
-      $li.find('.placeholder').hide();
+      $li.find('.placeholder').css({display:'none'});
     }
     else {
-      $li.find('.placeholder').show();
+      $li.find('.placeholder').css({display:'block'});
     }
   });
 
@@ -1340,7 +1340,7 @@ function initBillingInfoForm($form, options) {
       $opt.find('input[type=radio]').prop('checked', true);
 
       if($opt.is('.card_option')) {
-        // Show/hide is broken in jQuery 1
+        // Show/hide is broken in jQuery 1.9
         $form.find('.credit_card').css({display:'block'});
         $form.find('.paypal').css({display:'none'});
         $input.val('');

diff --git a/build/recurly.min.js b/build/recurly.min.js
diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,8 @@
 #Recurly.js CHANGELOG
 
+##Version 2.2.4 (Aug 23, 2013)
+- Workaround a bug in jQuery 1.9 that throws style undefined exceptions.  
+
 ##Version 2.2.3 (Aug 13, 2013)
 - Fix an issue where first/last name show up for PayPal when distinguishContactFromBillingInfo is true
 

diff --git a/examples/subscribe.html b/examples/subscribe.html
@@ -31,6 +31,9 @@
                     'american_express', 
                     'visa'],
     acceptPaypal: true,
+    subscription: {
+      couponCode: '123'
+    },
     account: {
       firstName: 'Joe',
       lastName: 'User',

diff --git a/src/js/ui.js b/src/js/ui.js
@@ -201,10 +201,10 @@ function initCommonForm($form, options) {
     var $li = $(this).parent(); 
 
     if($input.val().length > 0) {
-      $li.find('.placeholder').hide();
+      $li.find('.placeholder').css({display:'none'});
     }
     else {
-      $li.find('.placeholder').show();
+      $li.find('.placeholder').css({display:'block'});
     }
   });
 
@@ -281,7 +281,7 @@ function initBillingInfoForm($form, options) {
       $opt.find('input[type=radio]').prop('checked', true);
 
       if($opt.is('.card_option')) {
-        // Show/hide is broken in jQuery 1
+        // Show/hide is broken in jQuery 1.9
         $form.find('.credit_card').css({display:'block'});
         $form.find('.paypal').css({display:'none'});
         $input.val('');

diff --git a/version b/version
@@ -1 +1 @@
-2.2.3
+2.2.4