Uses stripe.handleNextAction for payment intents

recurly · Dec 4, 2024 · 3642335 · 3642335
1 parent 6b9d477
commit 3642335
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 9 deletions.
diff --git a/lib/recurly/risk/three-d-secure/strategy/stripe.js b/lib/recurly/risk/three-d-secure/strategy/stripe.js
@@ -7,6 +7,7 @@ const debug = require('debug')('recurly:risk:three-d-secure:stripe');
 export default class StripeStrategy extends ThreeDSecureStrategy {
   static libUrl = 'https://js.stripe.com/v3/';
   static strategyName = 'stripe';
+  static PAYMENT_INTENT_STATUS_SUCCEEDED = 'succeeded';
 
   constructor (...args) {
     super(...args);
@@ -40,15 +41,40 @@ export default class StripeStrategy extends ThreeDSecureStrategy {
 
     this.whenReady(() => {
       const isPaymentIntent = this.stripeClientSecret.indexOf('pi') === 0;
-      const handleAction = isPaymentIntent ? this.stripe.handleCardAction : this.stripe.confirmCardSetup;
-
-      handleAction(this.stripeClientSecret).then(result => {
+      const handleResult = result => {
         if (result.error) {
           throw result.error;
         }
         const { id } = result.paymentIntent || result.setupIntent;
         this.emit('done', { id });
-      }).catch(err => this.threeDSecure.error('3ds-auth-error', { cause: err }));
+      };
+      const handleError = err => this.threeDSecure.error('3ds-auth-error', { cause: err });
+
+      (() => (
+        isPaymentIntent
+          ? this.stripe.handleNextAction({ clientSecret: this.stripeClientSecret })
+          : this.stripe.confirmCardSetup(this.stripeClientSecret)
+      ))()
+        .then(handleResult)
+        .catch(err => {
+          // Handle a Payment Intent which has already had its action handled and succeeded
+          if (err.name === 'IntegrationError') {
+            return this.stripe.retrievePaymentIntent(this.stripeClientSecret)
+              .then(result => {
+                if (result.error) {
+                  throw result.error;
+                }
+
+                const { next_action: nextAction, status } = result.paymentIntent || result.setupIntent;
+                if (!nextAction && status === StripeStrategy.PAYMENT_INTENT_STATUS_SUCCEEDED) {
+                  return handleResult(result);
+                }
+              })
+              .catch(handleError);
+          }
+
+          return handleError(err);
+        });
     });
   }
 

diff --git a/test/unit/risk/three-d-secure.test.js b/test/unit/risk/three-d-secure.test.js
@@ -209,7 +209,7 @@ describe('ThreeDSecure', function () {
         { id: 'action-token-adyen', strategy: AdyenStrategy },
         { id: 'action-token-braintree', strategy: BraintreeStrategy },
         { id: 'action-token-sage-pay', strategy: SagepayStrategy },
-        { id: 'action-token-stripe', strategy: StripeStrategy },
+        { id: 'action-token-stripe-pi', strategy: StripeStrategy },
         { id: 'action-token-test', strategy: TestStrategy },
         { id: 'action-token-wirecard', strategy: WirecardStrategy },
         { id: 'action-token-worldpay', strategy: WorldpayStrategy }

diff --git a/test/unit/risk/three-d-secure/strategy/stripe.test.js b/test/unit/risk/three-d-secure/strategy/stripe.test.js
@@ -25,7 +25,7 @@ describe('StripeStrategy', function () {
       setupIntent: { id: 'seti-test-id', test: 'result', consistingOf: 'arbitrary-values' }
     };
     this.stripe = {
-      handleCardAction: sinon.stub().resolves(this.paymentIntentResult),
+      handleNextAction: sinon.stub().resolves(this.paymentIntentResult),
       confirmCardSetup: sinon.stub().resolves(this.setupIntentResult)
     };
     window.Stripe = sinon.spy(publishableKey => this.stripe);
@@ -78,8 +78,8 @@ describe('StripeStrategy', function () {
       it('instructs Stripe.js to handle the card action using the client secret', function () {
         const { strategy, target, stripe } = this;
         strategy.attach(target);
-        assert(stripe.handleCardAction.calledOnce);
-        assert(stripe.handleCardAction.calledWithExactly('pi-test-stripe-client-secret'));
+        assert(stripe.handleNextAction.calledOnce);
+        assert(stripe.handleNextAction.calledWithExactly({ clientSecret: 'pi-test-stripe-client-secret' }));
       });
 
       it('emits done with the paymentIntent result', function (done) {
@@ -95,7 +95,7 @@ describe('StripeStrategy', function () {
         beforeEach(function () {
           const { strategy } = this;
           this.exampleResult = { error: { example: 'error', for: 'testing' } };
-          strategy.stripe.handleCardAction = sinon.stub().resolves(this.exampleResult);
+          strategy.stripe.handleNextAction = sinon.stub().resolves(this.exampleResult);
         });
 
         it('emits an error on threeDSecure', function (done) {