improve testing with reculy IClient #671
Closed
+90
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change Cannot write unit tests with paging, because IClient returns Pager<T>, a type that mocking frameworks have hard time to create stubs of. Extracting a minimalistic interface, IPager<T>, and defining that as return type solves the issue.
The default literal was added in C# v7.1
quexy
force-pushed
the
v3-v2021-02-25
branch
from
99982a6 to
38c2fc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #663
This is a breaking change
Cannot write unit tests with paging, because IClient returns Pager,
a type that mocking frameworks have hard time to create stubs of.
Extracting a minimalistic interface, IPager, and defining that as
return type solves the issue.