Skip correct Collection<string, Training> fixture #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomasVotruba I am merging this fixture for proof to skip valid |
|
you're awesome @samsonasik thanks! now I need to upgrade to Rector 2.0 😁 |
|
is it also correctly skipped when the property is typed ? This was definitely not skipped for us in Rector 1.2.10 (the absence of tags in this repo makes it hard to know what was part of 1.2.10 vs 2.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yguedidi here the fixture, it correctly skipped
Ref #359 (comment)