Add return doc block to Collection property's getter method by ToMany attribute #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszutkowski
changed the title
jszutkowski
force-pushed
the
add-return-doc-block-by-property-attribute
branch
3 times, most recently
from
054c55c to
d8bedf0
Compare
jszutkowski
force-pushed
the
add-return-doc-block-by-property-attribute
branch
from
d8bedf0 to
ce70af7
Compare
|
Thanks for improvement. I've been doing this manually so many time... great rule 👍 It's ready to go for me. How about you? |
|
Good to go for me as well 👍 Do you think it's worth to have a similar rule that adds return type based on property's *ToMany annotation? |
|
Let's ship it :) I think that would be useful too 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the title - I added a class, that based on the property's OneToMany or ManyToMany attribute, adds
@returndoc block to a getter method.It adds the doc block only if method returns single property.
It also fixes invalid doc blocks like
@return Collection<Entity> -> @return Collection<int, Entity>.Any feedback appreciated