Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture for auto imported curly list #284

Closed
wants to merge 5 commits into from
Closed

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Feb 14, 2024

The one-liner to reproduce failng test case locally:

vendor/bin/phpunit rules-tests/CodeQuality/Rector/Class_/YamlToAnnotationsDoctrineMappingRector/ImportNamesYamlToAnnotationsDoctrineMappingRectorTest.php

While debugging I got into \Rector\BetterPhpDocParser\PhpDocParser\StaticDoctrineAnnotationParser\PlainValueParser, so I assume it will be somewhere in there. Possibly related to ArrayItemNode and \Rector\BetterPhpDocParser\ValueObject\PhpDoc\DoctrineAnnotation\CurlyListNode

@TomasVotruba TomasVotruba changed the title tv unique columns Add fixture for auto imported curly list Feb 14, 2024
@TomasVotruba TomasVotruba force-pushed the tv-unique-columns branch 2 times, most recently from 4e3ac5f to 708043a Compare February 14, 2024 14:43
@samsonasik
Copy link
Member

closing as conflict and handled in attribute transform at PR:

@samsonasik samsonasik closed this Feb 15, 2024
@samsonasik samsonasik deleted the tv-unique-columns branch February 15, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants