Convert annotations to attributes with known class references (#288)

rectorphp · Feb 14, 2024 · ad55a28 · ad55a28
1 parent 0858ab3
commit ad55a28
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 15 deletions.
diff --git a/config/sets/attributes/doctrine.php b/config/sets/attributes/doctrine.php
@@ -34,7 +34,7 @@
 
     $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
         // class
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\Entity'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\Entity', null, ['repositoryClass']),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\Column'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\UniqueConstraint'),
 
@@ -43,24 +43,24 @@
         new AnnotationToAttribute('Doctrine\ORM\Mapping\GeneratedValue'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\SequenceGenerator'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\Index'),
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\CustomIdGenerator'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\CustomIdGenerator', null, ['class']),
 
         // relations
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\OneToOne'),
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\OneToMany'),
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\ManyToMany'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\OneToOne', null, ['targetEntity']),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\OneToMany', null, ['targetEntity']),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\ManyToMany', null, ['targetEntity']),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\JoinTable'),
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\ManyToOne'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\ManyToOne', null, ['targetEntity']),
 
         new AnnotationToAttribute('Doctrine\ORM\Mapping\OrderBy'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\JoinColumn'),
 
         // embed
         new AnnotationToAttribute('Doctrine\ORM\Mapping\Embeddable'),
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\Embedded'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\Embedded', null, ['class']),
 
         // inheritance
-        new AnnotationToAttribute('Doctrine\ORM\Mapping\MappedSuperclass'),
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\MappedSuperclass', null, ['repositoryClass']),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\InheritanceType'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\DiscriminatorColumn'),
         new AnnotationToAttribute('Doctrine\ORM\Mapping\DiscriminatorMap'),

diff --git a/tests/Set/DoctrineORM29Set/Fixture/custom_id_generator.php.inc b/tests/Set/DoctrineORM29Set/Fixture/custom_id_generator.php.inc
@@ -22,7 +22,7 @@ use Doctrine\ORM\Mapping\CustomIdGenerator;
 
 class User
 {
-    #[CustomIdGenerator(class: 'MyIdGenerator')]
+    #[CustomIdGenerator(class: \MyIdGenerator::class)]
     private $id;
 }
 

diff --git a/tests/Set/DoctrineORM29Set/Fixture/embeddable_embedded.php.inc b/tests/Set/DoctrineORM29Set/Fixture/embeddable_embedded.php.inc
@@ -36,7 +36,7 @@ class Address
 
 class User
 {
-    #[Embedded(class: 'Address')]
+    #[Embedded(class: \Address::class)]
     private $address;
 }
 

diff --git a/tests/Set/DoctrineORM29Set/Fixture/fixture.php.inc b/tests/Set/DoctrineORM29Set/Fixture/fixture.php.inc
@@ -50,7 +50,7 @@ use Doctrine\ORM\Mapping as ORM;
  * News
  */
 #[ORM\Table(name: 'news')]
-#[ORM\Entity(repositoryClass: 'DoctrineFixtureDemo\Repository\NewsRepository')]
+#[ORM\Entity(repositoryClass: \DoctrineFixtureDemo\Repository\NewsRepository::class)]
 class News
 {
     /**

diff --git a/tests/Set/DoctrineORM29Set/Fixture/join_column_many_to_one.php.inc b/tests/Set/DoctrineORM29Set/Fixture/join_column_many_to_one.php.inc
@@ -36,7 +36,7 @@ use Doctrine\ORM\Mapping\JoinColumn;
 class User
 {
     #[JoinColumn(name: 'group_id', referencedColumnName: 'id')]
-    #[ManyToOne(targetEntity: 'HelloWorld\UserGroup', inversedBy: 'users')]
+    #[ManyToOne(targetEntity: \HelloWorld\UserGroup::class, inversedBy: 'users')]
     protected $group;
 }
 

diff --git a/tests/Set/DoctrineORM29Set/Fixture/join_column_one_to_one.php.inc b/tests/Set/DoctrineORM29Set/Fixture/join_column_one_to_one.php.inc
@@ -20,7 +20,7 @@ use Doctrine\ORM\Mapping\JoinColumn;
 class Product
 {
     #[JoinColumn(name: 'shipment_id', referencedColumnName: 'id')]
-    #[OneToOne(targetEntity: 'Shipment')]
+    #[OneToOne(targetEntity: \Shipment::class)]
     private $shipment;
 }
 

diff --git a/tests/Set/DoctrineORM29Set/Fixture/join_table_many_to_many.php.inc b/tests/Set/DoctrineORM29Set/Fixture/join_table_many_to_many.php.inc
@@ -20,7 +20,7 @@ use Doctrine\ORM\Mapping\JoinTable;
 class User
 {
     #[JoinTable(name: 'users_phonenumbers')]
-    #[ManyToMany(targetEntity: 'Phonenumber')]
+    #[ManyToMany(targetEntity: \Phonenumber::class)]
     public $phonenumbers;
 }
 

diff --git a/tests/Set/DoctrineORM29Set/Fixture/one_to_many.php.inc b/tests/Set/DoctrineORM29Set/Fixture/one_to_many.php.inc
@@ -22,7 +22,7 @@ use Doctrine\ORM\Mapping\OneToMany;
 
 class Product
 {
-    #[OneToMany(targetEntity: 'Feature', mappedBy: 'product')]
+    #[OneToMany(targetEntity: \Feature::class, mappedBy: 'product')]
     private $features;
 }