deprecate InitializeDefaultEntityCollectionRector, use ExplicitRelati…

…onCollectionRector instead
rectorphp · Mar 21, 2024 · 10195d4 · 10195d4
1 parent 8faab79
commit 10195d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/config/sets/doctrine-code-quality.php b/config/sets/doctrine-code-quality.php
@@ -4,7 +4,6 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Doctrine\CodeQuality\Rector\Class_\ExplicitRelationCollectionRector;
-use Rector\Doctrine\CodeQuality\Rector\Class_\InitializeDefaultEntityCollectionRector;
 use Rector\Doctrine\CodeQuality\Rector\Class_\MoveCurrentDateTimeDefaultInEntityToConstructorRector;
 use Rector\Doctrine\CodeQuality\Rector\Class_\RemoveEmptyTableAttributeRector;
 use Rector\Doctrine\CodeQuality\Rector\Property\CorrectDefaultTypesOnEntityPropertyRector;
@@ -22,9 +21,10 @@
         MakeEntityDateTimePropertyDateTimeInterfaceRector::class,
         MoveCurrentDateTimeDefaultInEntityToConstructorRector::class,
         CorrectDefaultTypesOnEntityPropertyRector::class,
-        ImproveDoctrineCollectionDocTypeInEntityRector::class,
-        InitializeDefaultEntityCollectionRector::class,
+
         ExplicitRelationCollectionRector::class,
+        ImproveDoctrineCollectionDocTypeInEntityRector::class,
+
         RemoveEmptyTableAttributeRector::class,
 
         // typed properties in entities from annotations/attributes

diff --git a/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php b/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php
@@ -19,6 +19,8 @@
  * @see https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/best-practices.html#initialize-collections-in-the-constructor
  *
  * @see \Rector\Doctrine\Tests\CodeQuality\Rector\Class_\InitializeDefaultEntityCollectionRector\InitializeDefaultEntityCollectionRectorTest
+ *
+ * @deprecated This rule can create incomplete assign of object to an array. Use the @see \Rector\Doctrine\CodeQuality\Rector\Class_\ExplicitRelationCollectionRector instead.
  */
 final class InitializeDefaultEntityCollectionRector extends AbstractRector
 {