Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Znk fix 106: update to {matchmaker} #107

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Znk fix 106: update to {matchmaker} #107

merged 4 commits into from
Feb 28, 2020

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Jan 22, 2020

  • Both clean_variable_spelling() and clean_spelling() have been migrated over
    to the {matchmaker} package and arguments from the aformentioned functions are
    passed to the {matchmaker} functions. Tests and documentation have been
    updated to reflect this.
  • Remove {rlang} from imports (but is still imported by {matchmaker}).

@zkamvar zkamvar requested a review from amygimma January 22, 2020 16:45
@zkamvar
Copy link
Member Author

zkamvar commented Feb 12, 2020

Note: depending on the order this and #109 are merged, one of these will have to fix a conflict in the version number/news

@amygimma amygimma merged commit cae034d into master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants