Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for entirely missing columns in guess_dates #109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Feb 10, 2020

This will return the column unchanged if encountered and will fix #108

@zkamvar
Copy link
Member Author

zkamvar commented Feb 10, 2020

@aspina7, can you check this with remotes::install_github("reconhub/linelist#109") and confirm that it works for you?

@aspina7
Copy link

aspina7 commented Feb 10, 2020

so it works for a character NA variable (returns only NAs). But i think the default for an entirely NA var is to be logical....

@zkamvar
Copy link
Member Author

zkamvar commented Feb 10, 2020

so it works for a character NA variable (returns only NAs). But i think the default for an entirely NA var is to be logical....

Okay, I've set it so that it will return the unmodified NA column before it panics about vector types. Try it now.

@aspina7
Copy link

aspina7 commented Feb 10, 2020

works a charm - maybe just specify in the warning which variable?

@zkamvar
Copy link
Member Author

zkamvar commented Feb 10, 2020

works a charm - maybe just specify in the warning which variable?

Again, difficult to do because the context of this function is on individual vectors. It doesn't know that these vectors come from a data frame.

@aspina7
Copy link

aspina7 commented Feb 10, 2020

ah true true sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown for an empty variable (only NAs)
3 participants