Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added charts to OpenSourceAnalysis #411

Closed
wants to merge 2 commits into from
Closed

Added charts to OpenSourceAnalysis #411

wants to merge 2 commits into from

Conversation

SimranShaikh20
Copy link
Member

Issue no - #406

@sanjay-kv i have added eda to open source analysis .
is there any conflits .

@github-actions GitHub Actions
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@SimranShaikh20 SimranShaikh20 changed the title Add charts to OpenSourceAnalysis Added charts to OpenSourceAnalysis Oct 21, 2024
sanjay-kv
sanjay-kv requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we dont want new folder structure, i was thinking you would be adding this to existing website as an enhancment

@SimranShaikh20
Copy link
Member Author

SimranShaikh20 commented Oct 22, 2024 •
edited
Loading

@sanjay-kv so i have to make changes in app. py file right?
To add eda in to that file!
Can you pls ellobrate what excetly your are expecting

@SimranShaikh20
Copy link
Member Author

@sanjay-kv can you please give me clarity where I have to add eda of open source either on note book file or in app. py file?

@SimranShaikh20
Copy link
Member Author

@sanjay-kv pls let me know where I have to make changes

@sanjay-kv
Copy link
Member

everything should go to app.py

@SimranShaikh20
Copy link
Member Author

@sanjay-kv
So only code I have to add ?
And whether I have to add charts?

@sanjay-kv
Copy link
Member

tbh it should work like enhancement .
means addition to the website. which includes charts and stuff. raise a another PR with readme change, I will give label for your work and close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjay-kv sanjay-kv sanjay-kv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimranShaikh20 @sanjay-kv