Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source Analysis #315 #318

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

ChethanaPotukanam
Copy link
Contributor

performed opensource_analysis on survey_results_sample_2018.csv.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@ChethanaPotukanam
Copy link
Contributor Author

@sanjay-kv I completed the issue assigned to me.Please review the PR.Let me know if there are any mistakes.I will rectify them.

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt make sense to me, we are building a single streamlit app to enhance the existing thing.
Adding multiple individual ipynb is not what we looking for.

  • don't see any respective issue you created for this.

@ChethanaPotukanam
Copy link
Contributor Author

@sanjay-kv I would like to add an app.py file to the Streamlit folder. This file will incorporate the analysis performed in the Jupyter notebook into the Streamlit app, making all functionalities and visualizations accessible through the app interface. Is this acceptable?

@ChethanaPotukanam
Copy link
Contributor Author

This PR address the issue #315

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to create a folder and add into it.

@sanjay-kv sanjay-kv merged commit c1cd726 into recodehive:main Jul 7, 2024
1 check passed
Copy link

github-actions bot commented Jul 7, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants