This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
VPCEndpointConnection: Filter state 'rejected' #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of managing VPCEndpointConnections, this commit extends the existing filter conditions to include the 'rejected' state alongside 'deleting' and 'deleted'. By doing so, we ensure that any VPCEndpointConnections in the 'rejected' state are appropriately filtered out, aligning with the intended behavior of the delete action, which is to reject the Endpoint Connection.
|
@der-eismann ping? |
43 tasks
|
@fridim Thank you for your first time contribution! As it happens this issue was reported in a couple different issues and pull requests and was ultimately implemented in the new active fork of aws-nuke via ekristen/aws-nuke#271 This project has now been deprecated in favor of this fork, which has been linked to from the main readme. Sven kindly granted me access to directly answer and close pull requests and issues so that we can notify users if their issues have been addressed or not. Please see the welcome issue for more information. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of managing VPCEndpointConnections, this commit extends the existing filter conditions to include the 'rejected' state alongside 'deleting' and 'deleted'.
By doing so, we ensure that any VPCEndpointConnections in the 'rejected' state are appropriately filtered out, aligning with the intended behavior of the delete action, which is to reject the Endpoint Connection.