Release v2.13 #1589

cfillion · 2021-12-16T00:53:02Z

This merges all pull requests that were ready for a new pre-release. Not included are the drafts (#1449, #1467, #1493, #1514), incomplete (#1291, #1444) and unreviewed PRs (#1301, #1562).

If there's nothing to add/changelog typos/other changes to make, all that's left is amending the last commit with the correct release date in the whatsnew then merging the branch into master.

The submodules WDL, TagLib are updated and reaper-sdk added (run git submodule update --init)
reaper_plugin_functions.h is read from the new official SDK repository if it doesn't exist in the vendor subfolder (delete to migrate to the new SDK)
The value of some cached CMake variables changed, recreating the build tree might be necessary if it was created against the master branch (IDEs should do this automatically)

Fixes #1438

Closes #1436

…91 chars This prevents missing \n at the end of long lines leading to a corrupted file. The long lines are still truncated when being read. Fixes #1439

… non-Windows SWELL skips line that do not contain =.

There is no need to make a copy of the string with all \n replaced by \0 when the original string can already have the \0.

…dows Fixes #1451.

The list was always scrolled to the top after clearing & rebuilding the entire list (+ an extra redraw causing flickering). Fixes #1456

selection to dynamic commands. Default number of slots is 16, max slots is SNM_MAX_DYN_ACTIONS. Using these actions will mark the project as dirty. Fixes: #1405

This commits makes AWClrTimeSelClkToggle construct a single instance of the ConfigVar (and also simplifies the condition).

…on click in ruler" settings Fixes #1442

Booleans are always true if they aren't false.

…n right clicking above the list on Linux and Windows HeaderHitTest is called from GetHitItem even when the position is outside the list view's rect. This was not handled. Regression from v2.12 via 81a23d3. Closes #1506

… if already contained in new filename/takename

… section or reversed Report: https://forum.cockos.com/showpost.php?p=2300847&postcount=2840

…is a chapter marker (REAPER v6.19+)

fixes #1470

…ps 33 to 64

closes #1209

…y exists, closes #407, closes #1498 combine 'Xenakios/SWS: Rename take source files...' and 'Xenakios/SWS: Rename takes and source files...' into one function for avoiding code duplication API: import GetPeakFileNameEx()

https://github.com/taglib/taglib/releases/tag/v1.12

…in NF_UpdateSWSMarkerRegionSubWindow description

…ash if MIDI octave display offset is set to a negative value https://forum.cockos.com/showpost.php?p=2421440&postcount=2918

Edgemeal · 2021-12-17T14:54:57Z

This is weird, I set name of a new track so SWS v2.12 auto colors it, then script optionally gets that track color, darkens the color and sets the track color, but with v2.13 instead of the track color getting darker it changes to a black color. If I force my script to wait a bit (using defer loop) then the track darkening works as it does in current SWS release. Very weird!

TESTED on: Win10_x64, REAPER 6.41 & v6.43_RC4
sws-2.13.0.0-Windows-x64-v2.13-8e57814d.exe

example,
NewTrackName = "Drums" -- SWS auto colors track to a light blue.
ControlKeyIsDown = false -- if true darken track color, but it doesn't work as expected with SWS 2.13.

function DarkenColor(trk_colr) -- simple color darkener
local r,g,b = reaper.ColorFromNative(trk_colr)
if b - 50 < 0 then b = 0 else b = b - 50 end
if g - 50 < 0 then g = 0 else g = g - 50 end
if r - 50 < 0 then r = 0 else r = r - 50 end
return reaper.ColorToNative(r,g,b)
end

track = reaper.GetTrack(0,0) -- SWS auto colors the track when named.
reaper.GetSetMediaTrackInfo_String(track, "P_NAME", NewTrackName, true )

-- Optionally make the track a slightly darker
if ControlKeyIsDown then reaper.SetTrackColor(track, DarkenColor(reaper.GetTrackColor(track))) end
-- with SWS v2.13 ^ this makes the track black instead of a darker blue.

Edgemeal · 2021-12-17T15:33:45Z

Guessing the problem is, if you try to get the color of a track right after SWS has auto colored it , 2.13 now returns the wrong value?

* AC_AUDIOIN (audio-input): track has an assigned audio input * AC_MIDIOUT (midi-output): track has an assigned hardware MIDI output

…ht' into v2.13

This allows for generalized scripts that take "arguments" by creating a cycle action that first uses this new ReaConsole command to prime a value in REAPER's non-persisted state, and then calling a custom script that subsequently reads the value.

…startup-action-functions' into v2.13

Broke since AppVeyor's September 2021 Ubuntu 18.04 image update

0065b61491a5580e3ee48b4c66d64c82176fe228 is required for enabling C++17, and also gets rid of all warnings about the register keyboard being deprecated.

cfillion · 2021-12-17T18:38:03Z

If I force my script to wait a bit (using defer loop) then the track darkening works as it does in current SWS release.

Auto-color was indeed changed to be asynchronous (triggering on the next defer tick). This was done for performance reasons for the new track I/O and instrument FX filters and was applied to all filters for consistency.

I've replaced that with a different solution (downside is it's unclear if it cover all cases, relies on REAPER sending redundant control surface notifications in a particular order).
EDIT: Yup, doesn't work in all cases (eg. toggling record arm of selected tracks can freeze REAPER for a while–weird that it works if unselected!).
EDIT2: Replaced with a more robust fix, thanks to @jeremybernstein's idea!

…ating tracks

cfillion · 2021-12-19T22:00:38Z

I've updated the release date to tomorrow.

AppVeyorBot · 2021-12-19T23:46:13Z

✅ Build sws 691-master completed (commit d1310bfde7 by @cfillion)

Windows 64-bit

Windows 32-bit

macOS x86 64-bit

build/sws-2.13.0.0-Darwin-x86_64-v2.13-d1310bfd.dmg

macOS x86 32-bit

build/sws-2.13.0.0-Darwin-i386-v2.13-d1310bfd.dmg

macOS ARM 64-bit

build/sws-2.13.0.0-Darwin-arm64-v2.13-d1310bfd.dmg

Linux x86 64-bit

build/sws-2.13.0.0-Linux-x86_64-v2.13-d1310bfd.tar.xz

Linux x86 32-bit

build/sws-2.13.0.0-Linux-i686-v2.13-d1310bfd.tar.xz

Linux ARM 64-bit

build/sws-2.13.0.0-Linux-aarch64-v2.13-d1310bfd.tar.xz

Linux ARM 32-bit

build/sws-2.13.0.0-Linux-armv7l-v2.13-d1310bfd.tar.xz

nofishonfriday · 2021-12-20T00:34:20Z

Just a (maybe silly) idea...how about following the Reaper release tradition and letting users announce new SWS releases in the forum (the last ones you announced iirc).
Not sure if it would happen though, maybe nobody notices (edit: though I'd guess at least some have pre-releases notification enabled) or bothers to post lol.

cfillion · 2021-12-20T21:01:15Z

I suppose the majority of users with pre-release notifications enabled aren't necessarily active on the forum anyway...

cfillion and others added 30 commits November 1, 2020 19:22

remove 8192 characters length limit in warning messages

d0b87ed

Fixes #1438

show a diagnostic message when a cycle action fails to be registered

f7610c8

Closes #1436

fix corruption of S&M_Cyclaction.ini when saving lines longer than 81…

f67f46b

…91 chars This prevents missing \n at the end of long lines leading to a corrupted file. The long lines are still truncated when being read. Fixes #1439

fix writing the "do not edit by hand" warning to cycle action .ini on…

bd2924c

… non-Windows SWELL skips line that do not contain =.

rewrite SaveIniSection without \n to \0 conversion

fe29109

There is no need to make a copy of the string with all \n replaced by \0 when the original string can already have the \0.

fix data loss when writing S&M_Cyclaction.ini larger than ~1MB on Win…

3b68192

…dows Fixes #1451.

fix dragging cycle action commands or region playlists when scrolled

76b54cd

The list was always scrolled to the top after clearing & rebuilding the entire list (+ an extra redraw causing flickering). Fixes #1456

Convert save/restore time selection and save/restore loop

9dad837

selection to dynamic commands. Default number of slots is 16, max slots is SNM_MAX_DYN_ACTIONS. Using these actions will mark the project as dirty. Fixes: #1405

use C++11 in configvar.h

2048b3b

refactor persisting configvar changes to .ini

6883aa8

refactor itemclickmovecurs access

1aaae11

This commits makes AWClrTimeSelClkToggle construct a single instance of the ConfigVar (and also simplifies the condition).

persist "link time selection and edit cursor" and "clear loop points …

f757eb4

…on click in ruler" settings Fixes #1442

remove unused AWRelEdge* functions

d9d216a

remove redundant inverse checks in conditions

a343a9a

Booleans are always true if they aren't false.

implement custom cursors on Linux

7ac38ca

fix a memory leak in GetMacroOrScript

fe9c148

add a "Add all regions to current playlist" action

128eed5

Xenakios Rename take source files: don't double-append file extension…

6c77fbd

… if already contained in new filename/takename

TakeRenaming: avoid size_t to int casting, remove unused bChanges

aea8662

TakeRenaming: t_renameparams struct: use C++ style

cfb658f

Xenakios Rename take(s) (and source files): make it work if take is a…

8d9f3b8

… section or reversed Report: https://forum.cockos.com/showpost.php?p=2300847&postcount=2840

ReaScript: CF_EnumMediaSourceCues() - optionally get if a source cue …

c191342

…is a chapter marker (REAPER v6.19+)

S&M {Copy,Cut,Paste,Remove} track grouping: support groups 33 to 64

dfb28f6

fixes #1470

S&M Set selected tracks to {first unused group,group n}: support grou…

fd61133

…ps 33 to 64

Loudness: add dual mono scanning mode

1f88d0b

closes #1209

update TagLib to v1.12

e799d54

https://github.com/taglib/taglib/releases/tag/v1.12

ReaScript documentation: fix broken link to NF_SetSWSMarkerRegionSub …

f5a72ce

…in NF_UpdateSWSMarkerRegionSubWindow description

SWS/FNG: Set selected MIDI items name to first note: fix potential cr…

b3eb57b

…ash if MIDI octave display offset is set to a negative value https://forum.cockos.com/showpost.php?p=2421440&postcount=2918

cfillion force-pushed the v2.13 branch from 0a11271 to e72f0f5 Compare December 16, 2021 03:58

This comment has been minimized.

Sign in to view

jeremybernstein and others added 12 commits December 17, 2021 13:18

Autocolor.app: add filters for additional track types

127e5b9

* AC_AUDIOIN (audio-input): track has an assigned audio input * AC_MIDIOUT (midi-output): track has an assigned hardware MIDI output

Merge branch 'jb/AdditionalTrackGestaltsForAutocolor' into v2.13

4a599a7

Merge remote-tracking branch 'nofish/zoom-actions-fix-lock-track-heig…

2516d27

…ht' into v2.13

Merge remote-tracking branch 'nofish/reascript-add-NF_global-project-…

bb8d258

…startup-action-functions' into v2.13

Merge branch 'fix-clipboard-compat-v5' into v2.13

bb1050a

Merge branch 'gettrackfxchain2' into v2.13

0acbe53

Merge branch 'setstringconfigvar' into v2.13

1c52c7e

ci: fix Linux 32-bit builds

ae2b7cd

Broke since AppVeyor's September 2021 Ubuntu 18.04 image update

use reaper_plugin.h from the new reaper-sdk repository

e428474

remove Optional suffix to CF_EnumMediaSourceCues's isChapterOut argument

7c47603

update WDL

cd23dd0

0065b61491a5580e3ee48b4c66d64c82176fe228 is required for enabling C++17, and also gets rid of all warnings about the register keyboard being deprecated.

cfillion force-pushed the v2.13 branch from e72f0f5 to d62e000 Compare December 17, 2021 18:35

cfillion force-pushed the v2.13 branch 2 times, most recently from 71e6bf1 to 5459fac Compare December 17, 2021 22:13

This comment has been minimized.

Sign in to view

cfillion added 2 commits December 19, 2021 16:56

auto color: fix performance regression when changing track I/O or cre…

bd0a69d

…ating tracks

bump version to 2.13

4ca0494

cfillion force-pushed the v2.13 branch from 5459fac to 4ca0494 Compare December 19, 2021 21:57

cfillion merged commit 4ca0494 into master Dec 20, 2021

cfillion deleted the v2.13 branch December 20, 2021 21:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.13 #1589

Release v2.13 #1589

cfillion commented Dec 16, 2021 •

edited

Loading

This comment has been minimized.

Edgemeal commented Dec 17, 2021 •

edited

Loading

Edgemeal commented Dec 17, 2021

cfillion commented Dec 17, 2021 •

edited

Loading

This comment has been minimized.

cfillion commented Dec 19, 2021

AppVeyorBot commented Dec 19, 2021

nofishonfriday commented Dec 20, 2021 •

edited

Loading

cfillion commented Dec 20, 2021

Release v2.13 #1589

Release v2.13 #1589

Conversation

cfillion commented Dec 16, 2021 • edited Loading

This comment has been minimized.

Edgemeal commented Dec 17, 2021 • edited Loading

Edgemeal commented Dec 17, 2021

cfillion commented Dec 17, 2021 • edited Loading

This comment has been minimized.

cfillion commented Dec 19, 2021

AppVeyorBot commented Dec 19, 2021

nofishonfriday commented Dec 20, 2021 • edited Loading

cfillion commented Dec 20, 2021

cfillion commented Dec 16, 2021 •

edited

Loading

Edgemeal commented Dec 17, 2021 •

edited

Loading

cfillion commented Dec 17, 2021 •

edited

Loading

nofishonfriday commented Dec 20, 2021 •

edited

Loading