[RNET-992] Add sync support for collections in mixed #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8611831031Details
💛 - Coveralls |
rorbech
changed the title
rorbech
force-pushed
the
cr/collections-in-mixed-sync
branch
from
6a05037 to
9bbfcb4
Compare
rorbech
requested review from
papafe and
nirinchev
and removed request for
papafe
papafe
reviewed
Mar 21, 2024
nirinchev
reviewed
Mar 21, 2024
papafe
reviewed
Apr 4, 2024
papafe
reviewed
Apr 4, 2024
| @@ -236,7 +246,7 @@ public class DataTypeSynchronizationTests : SyncTestBase | |||
| public void Dict_Binary() => TestDictionaryCore(o => o.ByteArrayDict, TestHelpers.GetBytes(10), TestHelpers.GetBytes(15), (a, b) => a.SequenceEqual(b)); | |||
|
|
|||
| [Test] | |||
| public void Property_Binary() => TestPropertyCore(o => o.ByteArrayProperty, (o, rv) => o.ByteArrayProperty = rv, TestHelpers.GetBytes(5), TestHelpers.GetBytes(10), (a, b) => a!.SequenceEqual(b!)); | |||
| public void Property_Binary() => TestPropertyCore(o => o.ByteArrayProperty, (o, rv) => o.ByteArrayProperty = rv, TestHelpers.GetBytes(5), TestHelpers.GetBytes(10)); | |||
There was a problem hiding this comment.
I adopted the pattern of using Assert.That with Is.EqualTo().Using() with the RealmValueWithCollections.RealmValueComparer. I guess it wraps non-RealmValues in RealmValues, but considered it easier than abstracting the comparison just for this single case.
papafe
reviewed
Apr 8, 2024
papafe
approved these changes
Apr 8, 2024
|
@nirinchev This is ready to merge for me if you have nothing against it 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds sync support for collections in mixed fields.
Fixes RNET-992
TODO
Changelog entryCollections in mixed is already part of the changelog.