[RNET-1121] Removed collection equality in RealmValue #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
approved these changes
Mar 13, 2024
| @@ -1533,8 +1533,6 @@ public bool Equals(RealmValue other) | |||
| RealmValueType.ObjectId => AsObjectId() == other.AsObjectId(), | |||
| RealmValueType.Guid => AsGuid() == other.AsGuid(), | |||
| RealmValueType.Object => AsIRealmObject().Equals(other.AsIRealmObject()), | |||
| RealmValueType.List => AsList().SequenceEqual(other.AsList()), | |||
| RealmValueType.Dictionary => AsDictionary().DictionaryEquals(other.AsDictionary()), | |||
| RealmValueType.Null => true, | |||
There was a problem hiding this comment.
This looks a bit suspicious 🤨
There was a problem hiding this comment.
The Null part? It got me for a second too 😁
Before the switch we check that the type of the two RealmValues is the same. So if they're both null they're automatically equal.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3552
TODO