Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2134 touch up the GHA release process based on the first full run #7730

Merged
merged 4 commits into from
May 31, 2024

Conversation

ironage
Copy link
Contributor

@ironage ironage commented May 24, 2024

Related to #7566 #7726 and #7727

The make-release action failed near the end:

Run juliangruber/merge-pull-request-action@9234b8714dda9a08f3d1df5b2a6a3abd7b695353
  with:
    github-token: ***
    number: 77[2](https://github.com/realm/realm-core/actions/runs/9216410854/job/25356630029#step:8:2)9
    method: squash
  env:
    PULL_REQUEST_NUMBER: 7729
Error: At least 1 approving review is required by reviewers with write access. - https://docs.github.com/articles/about-protected-branches

realm-core doesn't allow merging without reviewers which is a protection we have in place for a reason.
Until we can come up with a smart way to automate this while keeping our protections in place, I'll make this a manual step in the release process.

@ironage ironage self-assigned this May 24, 2024
@cla-bot cla-bot bot added the cla: yes label May 24, 2024
token: ${{ secrets.REALM_CI_PAT }}
token: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need any of the special abilities of the REALM_CI_PAT for this action. We should be fine with the default GITHUB_TOKEN (docs). One difference is that further github actions cannot be triggered by jobs using the GITHUB_TOKEN, but this is not an issue because the next step in the release process is to approve and manually merge the generated PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right - if you only work in the same repository and don't need subsequent workflows to trigger for any of the work GITHUB_TOKEN does then I'd say it's the best choice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming Yavor!

@ironage ironage requested a review from fealebenpae May 24, 2024 00:36
Copy link

coveralls-official bot commented May 24, 2024

Pull Request Test Coverage Report for Build james.stone_553

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.833%

Files with Coverage Reduction New Missed Lines %
src/realm/array_mixed.cpp 1 91.91%
test/fuzz_tester.hpp 1 57.73%
test/test_index_string.cpp 1 93.48%
src/realm/query_expression.cpp 2 86.62%
src/realm/sync/noinst/protocol_codec.hpp 3 74.03%
src/realm/sync/noinst/server/server_history.cpp 3 63.57%
test/fuzz_group.cpp 3 51.2%
test/test_thread.cpp 3 66.14%
src/realm/array_string.cpp 4 87.23%
test/object-store/util/sync/baas_admin_api.cpp 5 84.93%
Totals Coverage Status
Change from base Build 2339: 0.01%
Covered Lines: 214673
Relevant Lines: 236338

💛 - Coveralls

Copy link
Contributor

@jedelbo jedelbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the missing 'v' in the tag?

@fealebenpae fealebenpae removed their request for review May 24, 2024 11:28
@ironage
Copy link
Contributor Author

ironage commented May 24, 2024

How about the missing 'v' in the tag?

Good eye! Updated.

- input the base branch that you would like to make a release from (usually this will be "master").
- input the release version (eg. "10.14.7")
1. Go to the prepare-release [action](https://github.com/realm/realm-core/actions/workflows/prepare-release.yml) and click the "Run workflow" dropdown.
- Input the base branch that you would like to make a release from (usually this will be "master").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Input the base branch that you would like to make a release from (usually this will be "master").
- Select the base branch that you would like to make a release from (usually this will be "master") in the drop down.

- input the release version (eg. "10.14.7")
1. Go to the prepare-release [action](https://github.com/realm/realm-core/actions/workflows/prepare-release.yml) and click the "Run workflow" dropdown.
- Input the base branch that you would like to make a release from (usually this will be "master").
- Input the release version (eg. "10.14.7")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Update the version description on line 10 of prepare-release.yml, since this is used for the prompt text:
Enter the version of the new release (e.g., "10.123.1" or "4.5.0-CustDemo")

Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple of minor comments

Also, It would be nice if there was a way to print or output a link to the new PR that needs to be reviewed/approved as part of the release. Perhaps a job summary could be used for this?

@ironage ironage merged commit f3ef3d4 into master May 31, 2024
37 checks passed
@ironage ironage deleted the js/gha-release-fixes branch May 31, 2024 20:31
@ironage ironage mentioned this pull request May 31, 2024
4 tasks
@github-actions github-actions bot mentioned this pull request May 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants