-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCORE-2134 touch up the GHA release process based on the first full run #7730
Conversation
token: ${{ secrets.REALM_CI_PAT }} | ||
token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need any of the special abilities of the REALM_CI_PAT for this action. We should be fine with the default GITHUB_TOKEN (docs). One difference is that further github actions cannot be triggered by jobs using the GITHUB_TOKEN, but this is not an issue because the next step in the release process is to approve and manually merge the generated PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right - if you only work in the same repository and don't need subsequent workflows to trigger for any of the work GITHUB_TOKEN
does then I'd say it's the best choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming Yavor!
Pull Request Test Coverage Report for Build james.stone_553Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the missing 'v' in the tag?
Good eye! Updated. |
doc/development/how-to-release.md
Outdated
- input the base branch that you would like to make a release from (usually this will be "master"). | ||
- input the release version (eg. "10.14.7") | ||
1. Go to the prepare-release [action](https://github.com/realm/realm-core/actions/workflows/prepare-release.yml) and click the "Run workflow" dropdown. | ||
- Input the base branch that you would like to make a release from (usually this will be "master"). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Input the base branch that you would like to make a release from (usually this will be "master"). | |
- Select the base branch that you would like to make a release from (usually this will be "master") in the drop down. |
doc/development/how-to-release.md
Outdated
- input the release version (eg. "10.14.7") | ||
1. Go to the prepare-release [action](https://github.com/realm/realm-core/actions/workflows/prepare-release.yml) and click the "Run workflow" dropdown. | ||
- Input the base branch that you would like to make a release from (usually this will be "master"). | ||
- Input the release version (eg. "10.14.7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Update the version description on line 10 of prepare-release.yml
, since this is used for the prompt text:
Enter the version of the new release (e.g., "10.123.1" or "4.5.0-CustDemo")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a couple of minor comments
Also, It would be nice if there was a way to print or output a link to the new PR that needs to be reviewed/approved as part of the release. Perhaps a job summary could be used for this?
Related to #7566 #7726 and #7727
The make-release action failed near the end:
realm-core doesn't allow merging without reviewers which is a protection we have in place for a reason.
Until we can come up with a smart way to automate this while keeping our protections in place, I'll make this a manual step in the release process.