EthicalAd: specific placement for Antora and mdBook #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our heuristic to detect the documentation tool/theme and add specific `--readthedocs-*` CSS variables based on that for known tools/themes. Reference: readthedocs/readthedocs.org#11849 (comment)
|
I also added the placement for mdBook as well:
|
humitos
changed the title
ericholscher
approved these changes
Dec 18, 2024
| element = document.querySelector(selector); | ||
|
|
||
| if (this.elementAboveTheFold(element)) { | ||
| placement.classList.add("ethical-alabaster"); |
There was a problem hiding this comment.
Should we rename this something more generic?
There was a problem hiding this comment.
Yes. We should use something like ethical-light-theme; considering that we are using it for that use case. However, it's not a 1:1 match. We will need to keep -alabaster as well since there are some thing very specific to it, I think. I opened #477
|
Would be good to merge this 👍 |
|
Yeah, thanks for the review. This PR is based on #473. We can merge it once we have the underlying one merged as well. The referencing PR seems to be pretty close if we agree on the CSS variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #473