BREAKING CHANGE: Use project API endpoint to get details #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
added a commit
to edgarrmondragon/pep610
that referenced
this pull request
Aug 14, 2024
humitos
reviewed
Aug 14, 2024
Comment on lines
+31
to
37
| if (project.versioning_scheme === "single_version_without_translations") { | ||
| RTD_URL = RTD_PROJECT_DOMAIN; | ||
| } else { | ||
| RTD_URL = RTD_PROJECT_DOMAIN + `${RTD_PROJECT_LANGUAGE}/${PR_NUMBER}/`; | ||
| } else if (project.versioning_scheme === "multiple_versions_with_translations") { | ||
| RTD_URL = RTD_PROJECT_DOMAIN + `${project.language.code}/${PR_NUMBER}/`; | ||
| } else if (project.versioning_scheme === "multiple_versions_without_translations") { | ||
| RTD_URL = RTD_PROJECT_DOMAIN + `${PR_NUMBER}/`; | ||
| } |
There was a problem hiding this comment.
You can remove all this block here and use directly urls.documentation that will always point to the correct URL no matter what's the configuration of the project.
There was a problem hiding this comment.
That URL doesn't seem to point to the preview, though. Also, #42 (comment) gives me pause to making this change and suggests we should deprecate single-version in favor of versioning-scheme, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42
📚 Documentation preview 📚: https://readthedocs-preview--43.org.readthedocs.build/en/43/