Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package_json Gem requirement into migration doc #1353

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/migrating-from-react-rails-to-react_on_rails.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ In this guide, it is assumed that you have upgraded the `react-rails` project to
1. Update Deps

1. Replace `react-rails` in `Gemfile` with the latest version of `react_on_rails` and run `bundle install`.
2. Remove `react_ujs` from `package.json` and run `yarn install`.
3. Commit changes!
2. Add `package_json` in `Gemfile` ( if you don't have it already ) and run `bundle install`
3. Remove `react_ujs` from `package.json` and run `yarn install`.
4. Commit changes!

2. Run `rails g react_on_rails:install` but do not commit the change. `react_on_rails` installs node dependencies and also creates sample react component, Rails view/controller, and update `config/routes.rb`.

Expand Down