Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove link (aspnet-logger.md) #595

Merged
merged 1 commit into from
Jul 8, 2021
Merged

remove link (aspnet-logger.md) #595

merged 1 commit into from
Jul 8, 2021

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jul 6, 2021

upda issue #594

@Arhell Arhell linked an issue Jul 6, 2021 that may be closed by this pull request
@dpvreony
Copy link
Member

dpvreony commented Jul 7, 2021

this is out of date due to https://github.com/reactiveui/splat#microsoftextensionslogging ?

GitHub
Makes things cross-platform. Contribute to reactiveui/splat development by creating an account on GitHub.

@Arhell Arhell requested review from glennawatson and worldbeater and removed request for glennawatson and worldbeater July 7, 2021 17:10
@Arhell
Copy link
Member Author

Arhell commented Jul 7, 2021

What suggestions? Delete this file?

@dpvreony
Copy link
Member

dpvreony commented Jul 7, 2021

it might be worth merging this page and https://www.reactiveui.net/docs/handbook/logging/observable-logger under a page of something like "Choosing your logging output"

I would reference the new Splat packages but the post and observable logger project are still good sources of understanding on how you can do custom logging if still required, so keep it as something worth reading for those who want some insight and learning.

some of these bits came from splat was going through a lean spell of maintenance.

https://www.reactiveui.net/docs/handbook/logging/observable-logger needs looking at because it targets ReactiveUI 7 so raised reactiveui/splat#724

@glennawatson
Copy link
Contributor

@dpvreony If the content needs rewriting might be best if one of us do it. @Arhell sort of specialises in minor changes and does a lot of CSS changes.

@dpvreony
Copy link
Member

dpvreony commented Jul 8, 2021

i will sort, i did actually mean to put that and tag you to ensure it made sense.

@glennawatson
Copy link
Contributor

Yeah we've taken over stuff from @jcmm33 before, he is available on the slack channel to DM.

@Arhell Arhell marked this pull request as ready for review July 8, 2021 21:32
@glennawatson
Copy link
Contributor

Just recommend deleting the link for now. We'll chase up with @jcmm33 offline.

@Arhell Arhell changed the title update link (aspnet-logger.md) remove link (aspnet-logger.md) Jul 8, 2021
@Arhell
Copy link
Member Author

Arhell commented Jul 8, 2021

@glennawatson done

@glennawatson
Copy link
Contributor

Thanks :)

@Arhell Arhell merged commit ffa8c7c into main Jul 8, 2021
@Arhell Arhell deleted the upd branch July 8, 2021 23:45
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with docs/handbook/logging/aspnet-logger.md
3 participants