Added custom-dependency-inversion.md (#161) #161
Conversation
RLittlesII
changed the title
| public abstract class MyDependencyResolver : IMutableDependencyResolver | ||
| { | ||
| public abstract object GetService(Type serviceType, string contract = null); | ||
|
|
There was a problem hiding this comment.
hmm.. may want to provide a reference implementation to having a Dictionary even of items etc.
There was a problem hiding this comment.
Or maybe we should provide a production-ready custom dependency resolver implementation for a trendy DI container, like SimpleInjector or DryIoc that are loved by mobile developers for performance 🤔
There was a problem hiding this comment.
Specifically for the GetService method or for the entire implementation? I struggled with this primarily because I don't want to affect peoples design decisions too much. I could technically just rip the guts from ModernDependencyResolver that way if they copy/paste from the website, they will at least be baseline.
There was a problem hiding this comment.
@worldbeater I actually wrote this last night while I was implementing this for Autofac. I could provide that.
There was a problem hiding this comment.
@RLittlesII it'd be great! Autofac is an extremely popular DI container so we may attract more people by saying RxUI supports it
There was a problem hiding this comment.
Changed to an implementation of an AutofacDependencyResolver
There was a problem hiding this comment.
Changed to an implementation of an AutofacDependencyResolver
Could we have a look?
There was a problem hiding this comment.
I would suggest we put one popular DI engine in for the moment, then expand as people add more. Eg SimpleInjector etc.
| protected IMyContainer Container; | ||
|
|
||
| public MyDepedencyResolver(IMyContainer container) | ||
| { |
There was a problem hiding this comment.
Potentially you might want to talk about InitializeReactiveUI which will re-register all the IPlatformsRegister stuff into the new container.
There was a problem hiding this comment.
Adding something here is fine. There needs to be some verbiage on the site about those methods and what they do, which I think is beyond the scope of this page.
There was a problem hiding this comment.
Yeah I am going to go into a full run down how the internals of that work.
|
@glennawatson @worldbeater Updated with an Autofac implementation. |
RLittlesII
dismissed
glennawatson’s stale review
Made requested changes. Please review again.
|
|
||
| ```csharp | ||
| public class AutofacDependencyResolver : IMutableDependencyResolver | ||
| { |
There was a problem hiding this comment.
Worth fixing spacing issues :)
There was a problem hiding this comment.
Can't find the "Approve" button, but I approve. 👍
There was a problem hiding this comment.
Approve button is under the top right in the "Changes" screen.
| ```csharp | ||
| var resolver = new AutofacDependencyResolver(container); | ||
| resolver.InitializeSplat(); | ||
| resolver.InitializeReactiveUI(); |
There was a problem hiding this comment.
Add a comment something like
// These Initialize methods will add to your new container dependencies required by ReactiveUI
// and these must be present if you override with your own Locator.
Resolves #134