Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#938 Add default Run and Test mode. #939

Merged
merged 2 commits into from
Jul 24, 2022
Merged

#938 Add default Run and Test mode. #939

merged 2 commits into from
Jul 24, 2022

Conversation

adamradocz
Copy link
Contributor

Closes #938

What kind of change does this PR introduce?

Add default Run and Test mode to easily override the ModeDetector.OverrideModeDetector

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #939 (6e2fc1a) into main (fa2aed8) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
+ Coverage   75.11%   75.29%   +0.18%     
==========================================
  Files          92       93       +1     
  Lines        4894     4898       +4     
==========================================
+ Hits         3676     3688      +12     
+ Misses       1218     1210       -8     
Impacted Files Coverage Δ
src/Splat/ModeDetection/Mode.cs 100.00% <100.00%> (ø)
src/Splat/Logging/FullLoggerExtensions.cs 28.57% <0.00%> (+0.95%) ⬆️
src/Splat/Logging/WrappingFullLogger.cs 65.58% <0.00%> (+1.29%) ⬆️
...ceMonitoring/DefaultFeatureUsageTrackingSession.cs 72.00% <0.00%> (+4.00%) ⬆️
src/Splat/Logging/WrappingPrefixLogger.cs 70.58% <0.00%> (+5.88%) ⬆️
src/Splat/ModeDetection/ModeDetector.cs 92.30% <0.00%> (+23.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2aed8...6e2fc1a. Read the comment docs.

@ChrisPulman ChrisPulman merged commit 211f99d into reactiveui:main Jul 24, 2022
@adamradocz adamradocz deleted the DefaultTestAndRunMode branch July 24, 2022 14:18
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Test and Run mode
2 participants