Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add links in Configuring TypeScript section #1368

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

stanleyoos
Copy link
Contributor

No description provided.

@stanleyoos stanleyoos self-assigned this Aug 9, 2024
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for react-navigation-docs failed.

Name Link
🔨 Latest commit 48d3a85
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/66b62ca06e66af0008645d02

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for react-navigation-docs ready!

Name Link
🔨 Latest commit 88c7550
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-docs/deploys/66ced484b364d60008a00123
😎 Deploy Preview https://deploy-preview-1368--react-navigation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@satya164
Copy link
Member

This is good, but what I wanted to do is link to sections in this page from other parts of the documentations, so for example, if someone is using useNavigation, they have a link to check how to setup TypeScript for that.

@stanleyoos
Copy link
Contributor Author

@satya164 Did you mean something like this?
Should we improve Type checking with TypeScript page somehow or is it ok for now?

@stanleyoos stanleyoos requested a review from satya164 August 14, 2024 06:38
@stanleyoos stanleyoos marked this pull request as ready for review August 14, 2024 07:08
Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!

@stanleyoos stanleyoos merged commit 1af2f52 into main Aug 28, 2024
3 checks passed
@stanleyoos stanleyoos deleted the @stanleyoos/docs-add-links-in-configuring-ts-page branch August 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants