Fixed issue #907 TypeError: Cannot read property 'dismiss' of undefined

[herberthk]

Summary

The error was described in this issue

• What issues does the pull request solve? it solves this issue

Test Plan

What's required for testing? run the code below on android

                 <DateTimePicker
                        testID="dateTimePicker"
                        timeZoneOffsetInMinutes={0}
                        value={date}
                        mode={mode}
                        is24Hour={true}
                        display={Platform.OS === 'ios' ? 'inline' : 'default'}
                        onChange={onChange}
                        minimumDate={new Date()}
                    />

Compatibility

OS	Implemented
iOS	❌
Android	✅

Checklist

• I have tested this on a device and a simulator
• I added the documentation in README.md
• I updated the typed files (TS and Flow)
• I added a sample use of the API in the example project (example/App.js)
• I have added automated tests, either in JS or e2e tests, as applicable

[vonovak]

@herberthk hello and thanks for opening the PR.
I'm sure this fixes the error of "Cannot read property 'dismiss' of undefined" but I'd like to know first why pickers[mode] is undefined. It shouldn't be, as far as I can tell.
In the issue that you linked there's a lot of comments, but no one was able to provide a reproduction of the issue.

Right now, I see this more as a workaround rather than a solution. I'd like to know better what the underlying problem is in order to be able to assess if this is the right fix.

Can you provide more insight into what's happening?
Thank you

[herberthk]

@vonovak Thanks for your response and contribution to this project. I'm not sure why pickers[mode] is undefined but this error came after migrating to react-native 0.75.2 in my case, I upgraded to the latest version of this package thinking it will resolve the issue which was not the case. The error comes after selecting or picking the date.

The error on the app looks like this

The error in the terminal looks like this

This is my system information

I hope this helps
Thank you

[maiznadeem]

When can this be resolved? Or can I downgrade my version?

[herberthk]

@maiznadeem The maintainer is not responding yet this PR fixes the issue

[vonovak]

Hello,
I have responded in the review comment: #929 (comment)

Right now, I don't have the confidence that this fix is the correct fix. More investigation should be done to determine the cause of the issue, and then assess if this is the correct fix or not.

[sanchaz]

@maiznadeem see #907 (comment)
The issue seems to be that when choosing 'datetime' mode on android, the picker for date still appears.
If I run only date and time (I know this is documented), it works fine.
So no fixed needed, but to avoid these comments/issues... maybe throwing without even loading the picker?

[maiznadeem]

@maiznadeem see #907 (comment)
The issue seems to be that when choosing 'datetime' mode on android, the picker for date still appears.
If I run only date and time (I know this is documented), it works fine.
So no fixed needed, but to avoid these comments/issues... maybe throwing without even loading the picker?

Just realised! thanks I might need to make my own datetime picker now.

[sanchaz]

@maiznadeem see #907 (comment)
The issue seems to be that when choosing 'datetime' mode on android, the picker for date still appears.
If I run only date and time (I know this is documented), it works fine.
So no fixed needed, but to avoid these comments/issues... maybe throwing without even loading the picker?

Just realised! thanks I might need to make my own datetime picker now.

@maiznadeem the way it is usually done on android, if you look at google calendar for example, is that you show the date picker first and then the time picker as soon as the date picker returns. I would recommend following that pattern instead of rolling your own datetime picker.

[maiznadeem]

Just realised! thanks I might need to make my own datetime picker now.

@maiznadeem the way it is usually done on android, if you look at google calendar for example, is that you show the date picker first and then the time picker as soon as the date picker returns. I would recommend following that pattern instead of rolling your own datetime picker.

Haha, no I also meant searching for one like Tamagui or somewhere.

I could go with paper one, but it's such a pain, when handling validations, for example I want to select a date and time that is 3 hours from now. But the component returns me datetime values in UTC. I first need to extract time and date from each datetimes. And for example, in my current timezone, 3 hours from now might be the next day, but in UTC it's not, so validation also fails there.