Skip to content

Commit

Permalink
increment version, update NEWS, and prep for CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
timelyportfolio committed Feb 21, 2018
1 parent bc70bd0 commit fda9c58
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: reactR
Type: Package
Title: React Helpers
Version: 0.1.4
Date: 2017-11-21
Version: 0.2.0
Date: 2018-02-20
Authors@R: c(
person(
"Facebook", "Inc"
Expand Down
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
YEAR: 2017
YEAR: 2018
COPYRIGHT HOLDER: Kent Russell
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# reactR 0.2.0

* Update react and react-dom to 16.2.0
* Add core-js shim so that React will show up in RStudio Viewer

# reactR 0.1.4

* Update react and react-dom to 16.1.1
Expand Down
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ devtools::install_github("timelyportfolio/reactR")
library(reactR)
library(htmltools)

browsable(attachDependencies(
browsable(tagList(
tags$script(
"
ReactDOM.render(
Expand All @@ -33,6 +33,8 @@ browsable(attachDependencies(
)
"
),
#add core-js first to work in RStudio Viewer
html_dependency_corejs(),
html_dependency_react()
))
```
Expand All @@ -44,10 +46,12 @@ library(reactR)
library(htmltools)

browsable(
attachDependencies(
tagList(
tags$script(
babel_transform('ReactDOM.render(<h1>Powered By React/JSX</h1>,document.body)')
),
# add core-js shim first for React in RStudio Viewer
html_dependency_corejs(),
html_dependency_react()
)
)
Expand Down
6 changes: 1 addition & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
## Comments

**Resubmission**

1. Changed license to MIT to mirror change to MIT by Facebook/React
2. "React" should now be all uppercase
3. Do not want to add executable `babel_transform` example since many users do not use and do not want to have to install `V8`. Use of `V8` also makes testing difficult. However, it can be a very powerful tool when using with React, so I most definitely want to keep `babel_transform`.
none

## Test environments
* local Windows 10 install, R 3.4.0
Expand Down

0 comments on commit fda9c58

Please sign in to comment.