Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to contribute a refactor I authored while reverse-engineering this module. I'm tinkering with
react-virtual
and found this to be it's only major dependency. Wanted to in-house logic on my end so iterating off this fork; at some point found a quick PR to be in order.I've cleaned up the code to be more ES6'y and made it more readable. I've also pared down some unneeded steps and assertions. The algorithm should be a more efficient as a result, which is useful since it will run 60-120ips or more (especially on mobile).
To help with code-review:
serve
script and works fine.Feedback welcome!
Cheers