Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty publish (switch to NPM) #51

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Fix empty publish (switch to NPM) #51

merged 3 commits into from
Sep 18, 2024

Conversation

tpluscode
Copy link
Contributor

Superseeding #50, moving from yarn to npm should fix the accidental publishing problem

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 0a9a91b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rdfjs/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@matthieubosquet matthieubosquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think maybe the yarn command needs to be removed from the action steps to truly move away from Yarn?

EDIT: See an example action using pnpm.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@matthieubosquet matthieubosquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpluscode tpluscode merged commit f0302fc into master Sep 18, 2024
2 checks passed
@tpluscode tpluscode deleted the fix-empty-publish branch September 18, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants