Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namespace declarations on node elements and typed node elements #72

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

matthiaspalmer
Copy link
Contributor

Previous fixes only worked for namespace declarations on property elements.
Due to the striped syntax this was not enough.

Introduced test (and fix) for node elements and typed node elements.
Also divided the tests so there are separate tests for default namespace and specific namespace declarations.

@rubensworks
Copy link
Member

Thanks for the PR @matthiaspalmer.
It looks like there's a merge conflict though. Could you rebase your branch onto master?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6967271401

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6786033247: 0.0%
Covered Lines: 297
Relevant Lines: 297

💛 - Coveralls

@matthiaspalmer
Copy link
Contributor Author

matthiaspalmer commented Nov 23, 2023

Of course @rubensworks!
Should have done that from the start.
It is done now.

@rubensworks rubensworks merged commit 7e35733 into rdfjs:master Nov 24, 2023
13 checks passed
@rubensworks
Copy link
Member

Thanks! Released as 2.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants