Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatasetFactory parent #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thewilkybarkid
Copy link

Copy link
Member

@vhf vhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is correct as is, here's how I understand it:

DatasetFactory extends DataFactory, therefore an implementation of DatasetFactory would have all of these:

SomeDatasetFactory {
  // from DataFactory
  NamedNode namedNode(string value);
  BlankNode blankNode(optional string value);
  Literal literal(string value, optional (string or NamedNode) languageOrDatatype);
  Variable variable(string value);
  DefaultGraph defaultGraph();
  Quad quad(Term subject, Term predicate, Term object, optional Term? graph);
  Term fromTerm(Term original);
  Quad fromQuad(Quad original);
  // from DatasetFactory
  Dataset dataset(optional (Dataset or sequence<Quad>) quads);
}

I think another possibility would be to have DatasetCoreFactory extend DataFactory, then we could have DatasetFactory extend DatasetCoreFactory?

@bergos bergos self-requested a review December 3, 2019 13:58
@thewilkybarkid
Copy link
Author

thewilkybarkid commented Dec 3, 2019

I think another possibility would be to have DatasetCoreFactory extend DataFactory, then we could have DatasetFactory extend DatasetCoreFactory?

Could also just use unions of the two (reduces the requirements on implementing Dataset(Core)Factory).

@retog
Copy link

retog commented Jun 16, 2020

@ktk feel like reviewing this one too? It seems quite an obvious improvement compared with the status quo.

Btw, how does one get the review privilege?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants