-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf/better quad ids #318
Perf/better quad ids #318
Conversation
…den in the rdf-star spec
Co-authored-by: Ruben Verborgh <[email protected]>
store.getQuads( | ||
new Quad(new NamedNode('s1'), new NamedNode('p1'), new NamedNode('o2'), new NamedNode('g')), | ||
new NamedNode('p1'), | ||
null | ||
).length.should.equal(1); | ||
store.getQuads( | ||
new Quad(new NamedNode('s1'), new NamedNode('p1'), new NamedNode('o2'), new NamedNode('g2')), | ||
new NamedNode('p1'), | ||
null | ||
).length.should.equal(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid unnecessary breakage downstream; I have written this so that nested quads with graph terms that are not the default graph can still be added to the store (as this was the existing behavior when we were just stringifying quad terms).
This is never necessary for rdf-star compliant quoted triples; so we may wish to break this behavior at some point.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Main
Here
|
With the existing Main
Here
|
For Main
Here
|
This is a draft PR that branches on #311 and improves the indexing of quads in the store by using the existing numeric id's of other terms to generate the id of the quad as mentioned in #311 (comment).
Note there have been some changes to #311 since this was first opened so merge with care