[DE-6473] Add feature for trino-client helper rest api #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
utk-spartan
requested changes
Aug 16, 2024
vishwa05-rzp
force-pushed
the
trino-helper-client
branch
from
f6c1b98
to
a8e7184
Compare
utk-spartan
requested changes
Aug 20, 2024
utk-spartan
requested changes
Aug 20, 2024
| } | ||
|
|
||
| func (client *Client) Query(query string) (*sql.Rows, error) { | ||
| return client.db.Query(query) |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
utk-spartan
force-pushed
the
trino-helper-client
branch
from
7ab5004
to
f22ae6a
Compare
…wed threshold before loading in memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR adds the trino-rest api feature
Brief change log
Relevant document links
(Please attach relevant documents)
JIRA Link
(https://razorpay.atlassian.net/browse/DE-6473)
Committer checklist
Have useful descriptions and titles
Has a corresponding JIRA in PR
Commit message is descriptive of the change
Added documentation for new or modified features or behaviors
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
Added unit tests or modified existing tests to cover new code paths (if applicable)
Add some screenshots for front-end changes (if any)