Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an user should not delete the related items created by that user. #11

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

GabrielDumbrava
Copy link

No description provided.

@razisayyed
Copy link
Owner

Hi @GabrielDumbrava,

Sorry for taking too long to Comment on your PR. I was very busy in the past few months, and I could not manage to update django-ads.

I already extracted most of the changes in your PR and added them to original Repo.

I did not extract changes made to use filer, because I created this package to use it in a project (blog), and I do not use filer in it. I think it is better to create another package to be used on filer, or may be we can add filer as an optional requirement and add an option (lets say ADS_USE_FILER) to activate it.

the idea is to add different field for filer.

if ADS_USE_FILER is False then this field will be hidden in admin, and the original field will be visible. and vice versa. we can then add get_image to AdImage model that will return the appropriate image in the template.

The only problem in the approach is that it will make filer and easy_thumbnails as requirements to your app. which will make it very hard to use this package in projects that use sorl-thumbnail package (which is the case of my project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants